With the new
cpplint, there are some additional defaults, which are currently disabled but I would like to enforce, namely:
These essentially end causing changes akin to the following
#ifndef STAN_MATH_REV_FUN_VARIANCE_HPP -> #ifndef STAN_MATH_REV_FUN_VARIANCE_HPP_ #endif -> #endif // STAN_MATH_REV_FUN_VARIANCE_HPP_ For a static/global string constant, use a C style string instead: "const char MAJOR_VERSION".  stan/math/rev/functor/cvodes_ode_data.hpp(195): error cpplint:[build/include_what_you_use] Add #include <utility> for move 
Since enabling these for the
math library will involve making changes in the
stan repo, and also will cause much breakage for anyone working with a fork right now, I was hoping to get some opinions about this change.