I guess that will still plot y as lines but it will also overlay the points. If you prefer just the points and no line for y then I think that will require a slight change to the ppc_ribbon code but it’s not hard. If you want to open an issue for it at the bayesplot repo that would be great. I can probably get to it pretty quickly.
I find this pretty satisfactory. The only thing that bothers me is the legend: for y it should only include a point and for y_rep a ribbon. I know it’s possible to customize legends, but rather than doing it for this specific case, is there a way of fixing this issue globally?
Also @jonah, how do the unit tests run? I figure the relevant file is test-ppc-intervals.r and I’d need to add a visual test. But I’m not sure how to run the test, since not all dependency are on the R script.
I’m not 100% sure, I’d need to spend some time playing around with but I don’t quite have the time right now. I definitely remember it being tricky to get the legends right when y and yrep are using different geoms, but it’s been a while since I last tried to mess around with the legends so I don’t fully remember.
Where can I specify the benchmark for the unit test? So I’m looking at the following code and it’s not clear to me how the first argument of expect_doppelganger is specified (or how it would point to a benchmark)