@syclik sure, it’s not too premature.
So for devs + reviewers:
It’s easiest for @roualdes and I with this back and forth, but I would appreciate some feedback. We’re trying to be as thorough as possible with the git commit history, so that it’s easy to track what each change was. We can figure out what’s being automated with the flattening script, or searching Edward’s name as commit author.
What needs a closer look is what I’ve had to fix afterward, and I’ve tried to indicate these edits with the git history. Moving forward I’ll put a unique id:
script_exception so they’re easier to search for in git commit messages (didn’t do this with prim).
Mostly we’ve been pretty fortunate and these changes weren’t so bad. Here are some hashes on the branch
This commit is something that’s straightforward:
and here’s some examples where I’m less sure that my changes are valid:
I can easily revert all these as they’re disjoint and changes only span one file.
Any thoughts? There’s really only around 10 edits so far after the massive flatten.
As for timing, it’s as fast as we can (together) make sure these changes are valid and make these changes to
fwd. I’m anticipating these being less trivial.