I definitely agree. I was delibelatery holding off working on this for a few months because I knew there would be a doc avalanche triggered by it. And I am kind of responsible for getting this doced, seeing as I added it to stanc3.
We definitely need good examples and docs, otherwise no one will know this exists.
I had a look and I think it needs improved. Like, 45 minutes just zoom some stuff out and put a pull in docs so we can discuss.
Like, one problem is the title is âCustom Probability Functionsâ and it doesnât really show you all the steps to do a custom probability function. I think it will be easy to tag on the new lupdf/lupmf stuff once we have a foundation but Iâm not sure itâs there yet.
@jonah actually I donât know where people first stumble on _lpdf vs. ~ statements. Maybe we need a new userâs guide section thing altogether.
âProportionality constantsâ, and then it can be like @bgoodri said and we can talk about when you need the normalizing terms and when you donât. Should be pretty short and can give a shoutout to common problems interpreting log densities (target also includes Jacobian terms, etc.)
Yeah I think this is a good point. Especially since this is one of the most common ways that Stan programs differ from each other it could be good to have a separate section for it. Also, the interpretation of sampling statements is one of the more confusing things for new users so thatâs also a good reason to give it more/separate attention.