@rok_cesnovar I think the math pull slowdown is from the elementwise checks (here). What do we do here? I think the code is good, but clearly it’s slowing things down as it’s implemented now. Do we just revert it and make it an open pull request again?
I wanted this for the variadic ODEs (better error messages), but we could remove it (there are checks in the variadic ODEs pull, so all the same errors get caught, just not as cleanly).
Here are the relevant benchmarks:
July 13th (before): a3f438bd4916bc7afee3e3c147e8320b09cef386
4.0s, 4.0s, 4.0s, 4.0s
July 14th (after): e5f00e2e053da20400f729f1bc7198ca3b3e8955
4.4s, 4.3s, 4.4s, 4.2s
Edit: Discourse wouldn’t let me post three times in a row, but I did some stanc3 tests:
I suspect the stanc3 thing is this pull: https://github.com/stan-dev/stanc3/pull/521
I went through the stanc3 binaries that compiled here and tried them out with a develop cmdstan with 2.23 math: https://jenkins.mc-stan.org/job/stanc3-test-binaries/
These are the relevant numbers:
May 8th, #83
4.0s, 4.0s, 4.0s, 4.1s
May 11th, #85
4.3s, 4.1s, 4.1s, 4.4s
May 16th, #86
4.5s, 4.5s, 6.2s, 4.5s