Required reviews for pystan repos?

pystan

#1

What do people think about turning on required “reviews” (the github feature) for httpstan and pystan? This would create additional work for people but would also have some advantages.

In particular, I’m thinking about turning on required reviews for httpstan and pystan after the first release of PyStan 3.

/cc @ahartikainen


#2

Sounds good to me.


#3

I have this turned on for most of the R
packages too.


#4

Up to you, but there’s a lot to be said for code reviews. The problem is always finding enough reviewers and encouraging others to review so it doesn’t just have to be you. We’re still trying to get better at this for the stan and math repos.