I liked how that “what is PEP-8” talk you referred me to to understand what “pythonic” meant started by mocking a code review in the style you suggest as being from someone who’s had “management training”. We could all stand to sound more like politically correct managers and less like disgruntled programmers.
This is what led us into governance discussions—who’s allowed to code review in each repo?
Absolutely. I’m trying to balance that with my being too prompt stepping on other developer’s toes. People asked me to back off.
I agree with Mitzi that this is mostly programmer training. It took Daniel and I a long time to figure out a lot of the C++ idioms and the code still reflects some of our earlier bad decisions (though most have been refactored away at this point).
I can do that for the language PRs, of which there are very few. I imagine Michael will be OK with the language PRs (that is, we have responsibilities divided in stan-dev/stan, with nobody covering the services). Also, not sure we have anyone in charge of CmdStan. Daniel would draw the short straw for this, since the most frequent and most complex pull requests (like MPI, GPU, all the sparse matrix autodiff) are in the math lib.