Anyone seen this before? in AgradRevMatrix.mat_cholesky_1st_deriv_large_gradients: C++ exception with description "cholesky_decompose: Matrix m is not positive definite" thrown in the test body.
[ RUN ] AgradRevMatrix.mat_cholesky_1st_deriv_large_gradients
unknown file: Failure
C++ exception with description "cholesky_decompose: Matrix m is not positive definite" thrown in the test body.
[ FAILED ] AgradRevMatrix.mat_cholesky_1st_deriv_large_gradients (39440 ms)
Apparently this test normally takes ~80 seconds to run so the time is not that weird…
It’s in a pull request where I changed only things relating to the distribution tests so I find this regression pretty weird, seems like it could be a spurious error I’d like to eliminate if anyone has any ideas.
Are those tests random? If they aren’t, I would assume unsafe memory usage.
If this is happening on certain configurations, we saw something similar with Eigen and its initialization. If I remember correctly, on Mac, the default was Eigen set everything to 0, but in linux, it didn’t. That lead to failures when elements weren’t initialized to a value explicitly. (We fixed that with an Eigen typedef, but this is just what I tend to think about when there are random failures.)